Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Catalog] ModuleTemplate misses .spec.version and .spec.moduleName, but includes annotation operator.kyma-project.io/module-version #113

Closed
c-pius opened this issue Nov 27, 2024 · 0 comments · Fixed by #114
Assignees
Labels
bug Something isn't working

Comments

@c-pius
Copy link
Contributor

c-pius commented Nov 27, 2024

Description

Filip reported that our testing ModuleTemplates for template operator miss the .spec.version and .spec.moduleName fields.

Expected result

modulectl create using config:

name: kyma-project.io/module/template-operator
version: 1.0.3
# ...

Creates ModuleTemplate like:

apiVersion: operator.kyma-project.io/v1beta2
kind: ModuleTemplate
metadata:
  name: template-operator-1.0.3
  namespace: kcp-system
  labels:
    "operator.kyma-project.io/module-name": "template-operator"
  annotations:
    # "operator.kyma-project.io/module-version": "1.0.3"  THIS SHOULD BE GONE
spec:
  version: 1.0.3
  moduleName: template-operator

Actual result

apiVersion: operator.kyma-project.io/v1beta2
kind: ModuleTemplate
metadata:
  name: template-operator-1.0.3
  namespace: kcp-system
  labels:
    "operator.kyma-project.io/module-name": "template-operator"
  annotations:
    "operator.kyma-project.io/module-version": "1.0.3"  # STILL EXISTS
spec:
  # version MISSING
  # moduleName MISSING

Steps to reproduce

Troubleshooting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants