Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Watcher CR state handling #302

Closed
3 tasks done
fourthisle opened this issue Nov 7, 2022 · 1 comment · Fixed by #520
Closed
3 tasks done

Implement Watcher CR state handling #302

fourthisle opened this issue Nov 7, 2022 · 1 comment · Fixed by #520
Assignees
@fourthisle

Comments

@fourthisle
Copy link
Contributor

fourthisle commented Nov 7, 2022 •
edited
Loading

Description
We are missing a state on Watcher CR if the Virtual Service has been created/updated correctly.

Reasons
Central (in-KCP) Module developers would like to know what is the state of the resources managed by the Watcher Reconciler.

ACs

  • Propose a solution regarding the State object, we can do something similar to the one in Kyma CR
  • Implement state handling for watcher CRs in the watcher reconciler
  • Implement tests for state handling

Related discussions
#277 (comment)
@fourthisle fourthisle mentioned this issue Nov 7, 2022
Merged
7 tasks
@fourthisle fourthisle removed their assignment Nov 22, 2022
@fourthisle fourthisle reopened this Nov 23, 2022
@fourthisle fourthisle changed the title Assess if Watcher CR state handling should be implemented Implement Watcher CR state handling Nov 28, 2022
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2023
@janmedrek janmedrek removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2023
@fourthisle fourthisle self-assigned this Mar 31, 2023
@fourthisle fourthisle mentioned this issue Apr 11, 2023
Merged
@ruanxin ruanxin mentioned this issue Apr 11, 2023
Merged
@kyma-project kyma-project deleted a comment from jakobmoellerdev Apr 11, 2023
@fourthisle fourthisle removed their assignment Apr 12, 2023
@ruanxin ruanxin self-assigned this Apr 12, 2023
@fourthisle fourthisle assigned fourthisle and ruanxin and unassigned ruanxin and fourthisle Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fourthisle fourthisle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement watcher state handling
4 participants
@ruanxin @janmedrek @kyma-bot @fourthisle