Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate package in pkg folder to internal since none of the current packages are designed for sharing purposes #2143

Open
1 task
ruanxin opened this issue Dec 20, 2024 · 0 comments
Labels
area/quality Related to all activites around quality

Comments

@ruanxin
Copy link
Contributor

ruanxin commented Dec 20, 2024

Description

In Go projects, the pkg folder is typically used to store packages intended for use by other projects. However, for existing packages under lifecycle manager pkg , none of them are designed for sharing purposes. We should put them under internal as private package

Reasons

Aligned with Golang project structure best practices.

https://github.com/golang-standards/project-layout/tree/master/pkg

Acceptance Criteria

  • relocate package under pkg folder to internal

Feature Testing

No response

Testing approach

No response

Attachments

No response

@ruanxin ruanxin added kind/feature Categorizes issue or PR as related to a new feature. area/quality Related to all activites around quality and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality
Projects
None yet
Development

No branches or pull requests

1 participant