Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify statehandling for "installation state", "manager state", "business state" #2102

Open
2 tasks
c-pius opened this issue Dec 9, 2024 · 0 comments
Open
2 tasks
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Dec 9, 2024

Description

Follow-up from discussing: #1831

kyma-project/community#899 aligned that a module's state is separated into two distinct statues:

  • a) the "installation state"
    • determines if the module has been installed successfully
    • written by KLM
    • written as ManifestCR.status, synced into KymaCR.status.modules[].status
  • b) the "business state"
    • determines if the module is functioning as expected (failures caused e.g. by invalid configurations)
    • written by the module manager
    • written as `DefaultCR.status

For the "installation state", KLM is currently considering two things, first whether the resources from the raw manifest were applied successfully, second whether the module manager (deployment or replica set) came up successfully. The second step currently raises some concerns as KLM is just looking for the first deployment / replica set in the manifest and assumes it is the module manager, even if there is a problem with the manager coming up, KLM cannot resolve this situation.

Therefore the question, whether this should be re-designed. E.g., the UI could use the manager information from the new module templates and directly display its state.

Reasons

Have a consistent and transparent state management.

Acceptance Criteria

  • Clarified how we want to continue with the state handling
  • Created the necessary follow-ups as needed

Feature Testing

No response

Testing approach

No response

Attachments

No response

@c-pius c-pius added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant