Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deletion Modes] Remove the old module deletion logic in manifest reconciliation #1586

Closed
1 task
nesmabadr opened this issue May 28, 2024 · 0 comments
Closed
1 task
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nesmabadr
Copy link
Contributor

Description

After introducing #1211, we need to remove the old logic of module deletion which includes the module cr pre deletion hook.

Reasons

As a migration period, we decided to support having the old deletion logic when the deletion mode is empty, so after we introduce the default value of Ignore to the deletionMode, we need to remove the old legacy code.

Acceptance Criteria

  • Remove the old legacy code of module CR pre-deletion in the manifest reconciliation

Feature Testing

No response

Testing approach

No response

Attachments

No response

@nesmabadr nesmabadr added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2024
@nesmabadr nesmabadr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant