Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Provision Service Class' form does not support regex validation #1891

Closed
adamwalach opened this issue Dec 3, 2018 · 3 comments
Closed

'Provision Service Class' form does not support regex validation #1891

adamwalach opened this issue Dec 3, 2018 · 3 comments
Assignees
Labels
area/busola Related to all activities around the Busola UI and all its views area/service-management Issues or PRs related to service management kind/bug Categorizes issue or PR as related to a bug.

Comments

@adamwalach
Copy link
Contributor

Description

On the "Provision Service Class" form for "Google Cloud Storage"
screen shot 2018-12-03 at 09 04 40

the "Bucket ID" field has in the definition additional properties for validation:
screen shot 2018-12-03 at 09 29 32

Properties: maxLength, minLength and pattern are not supported. I was able to submit the form with values that were two characters long or contained only "/" characters

Expected result

The submit action should fail with a proper error message just like it does when mandatory fields are empty.

Actual result

Submit action of the form works and the creation process fails in next step

Steps to reproduce

Create new "Google Cloud Storage" service (from the GCP Broker Bundle) and try to provide incorrect values in the form.

Specification: GoogleCloudStorage.json.zip

@adamwalach adamwalach added kind/bug Categorizes issue or PR as related to a bug. area/service-management Issues or PRs related to service management area/busola Related to all activities around the Busola UI and all its views labels Dec 3, 2018
@adamwalach adamwalach added this to the Backlog_Wookiee milestone Dec 3, 2018
@adamwalach adamwalach changed the title 'Provision Service Class' form does not support reqex validation 'Provision Service Class' form does not support regex validation Dec 3, 2018
@PK85
Copy link
Contributor

PK85 commented Dec 3, 2018

ServiceBinding form as well

@derberg derberg modified the milestones: Backlog_Wookiee, Sprint_Wookiee_9 Jan 4, 2019
@aerfio aerfio self-assigned this Jan 7, 2019
@mjasinski5 mjasinski5 modified the milestones: Sprint_Wookiee_9, Sprint_Wookiee_10 Jan 14, 2019
@derberg
Copy link

derberg commented Jan 14, 2019

We need to clarify where fix the issue

  • gcp broker and the schema definition?
  • react schema lib and its dependencies?
  • kyma itself

Some investigation is needed

@aerfio
Copy link
Contributor

aerfio commented Jan 16, 2019

Hopefully this PR will take care of this issue: rjsf-team/react-jsonschema-form#1130

@mjasinski5 mjasinski5 modified the milestones: Sprint_Wookiee_10, Sprint_Wookiee_11 Jan 28, 2019
@mjasinski5 mjasinski5 modified the milestones: Sprint_Wookiee_11, Sprint_Wookiee_12 Feb 11, 2019
@mjasinski5 mjasinski5 modified the milestones: Sprint_Wookiee_12, Sprint_Wookiee_13 Feb 25, 2019
@aerfio aerfio closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/busola Related to all activities around the Busola UI and all its views area/service-management Issues or PRs related to service management kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants