Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated K8s resource API versions #11170

Closed
2 tasks
clebs opened this issue Apr 22, 2021 · 4 comments
Closed
2 tasks

Upgrade deprecated K8s resource API versions #11170

clebs opened this issue Apr 22, 2021 · 4 comments
Assignees
Labels
area/installation Issues or PRs related to installation

Comments

@clebs
Copy link
Contributor

clebs commented Apr 22, 2021

Description

Several resource versions have been deprecated and will soon be removed from Kubernetes.
The current resources need to be updated as follows (list ongoing):

  • rbac.authorization.k8s.io/v1beta1:ClusterRole -> rbac.authorization.k8s.io/v1:ClusterRole
  • apiextensions.k8s.io/v1beta1:CustomResourceDefinition -> apiextensions.k8s.io/v1:CustomResourceDefinition

Reasons
Prepare to be compatible with future Kubernetes versions

@halamix2
Copy link
Member

halamix2 commented Apr 22, 2021

Copied from #10497:

  • rbac.authorization.k8s.io/v1beta1:ClusterRoleBinding -> rbac.authorization.k8s.io/v1:ClusterRoleBinding
  • rbac.authorization.k8s.io/v1beta1:Role -> rbac.authorization.k8s.io/v1:Role
  • rbac.authorization.k8s.io/v1beta1:RoleBinding -> rbac.authorization.k8s.io/v1:RoleBinding
  • admissionregistration.k8s.io/v1beta1:ValidatingWebhookConfiguration -> admissionregistration.k8s.io/v1:ValidatingWebhookConfiguration
  • admissionregistration.k8s.io/v1beta1:MutatingWebhookConfiguration -> admissionregistration.k8s.io/v1:MutatingWebhookConfiguration

@lilitgh lilitgh added the area/quality Related to all activites around quality label Apr 26, 2021
@werdes72 werdes72 added this to the 1.23 milestone May 4, 2021
@a-thaler a-thaler removed this from the 1.23 milestone May 21, 2021
@a-thaler a-thaler changed the title Upgrade K8s resource API versions Upgrade deprecated K8s resource API versions May 21, 2021
@werdes72 werdes72 assigned werdes72 and unassigned colunira May 26, 2021
@werdes72 werdes72 added area/installation Issues or PRs related to installation and removed area/quality Related to all activites around quality labels May 26, 2021
@strekm
Copy link
Contributor

strekm commented Jun 23, 2021

it was agreed that:

other than that we found bunch ofc crds which are not located in cluster-essentials or installation/resources/crd:

  • components/compass-runtime-agent/internal/compassconnection/testdata/compass-connection.crd.yaml -> i proposed to handle it in application-connector PR mentioned above
  • components/eventing-controller/config/crd/external/apirules-gateway-kyma-project-io.yaml -> will be handled by @k15r team
  • installation/resources (installer-local, installer, release-adder): @werdes72 lets bump it
  • installation/resources/crds/compass-runtime-agent/compass-connection.crd.yam -> can be handled with PR to application-connector crds
  • installation/resources/crds/tracing/jaegers.jaegertracing.crd.yaml: Add jaegertracing crd #11532 and pushed to @a-thaler
  • resources/cert-manager/templates/crds.legacy.yaml -> this one will be gone soon

@rakesh-garimella
Copy link
Contributor

@werdes72 Created the PR for bumping the apiextensions.k8s.io/v1beta1 -> apiextensions.k8s.io/v1. However this requires additional change in installation package in hydroform which has been performed in this PR. But these changes when applied to kyma cli will break the installation for the kyma version upto 1.24 and so the installer needs to be made aware of the kyma version.

However in my opinion the effort of making this work would be huge compared to the result achieved since anyways as the changes performed in the PRs would be obsolete once we have kyma 2.0

@strekm
Copy link
Contributor

strekm commented Jul 29, 2021

all PRs have been merged, we ccan close this task

@strekm strekm closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installation Issues or PRs related to installation
Projects
None yet
Development

No branches or pull requests

8 participants