Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote GA Pipeline - Ignore Whitespaces in Bump Check #1622

Open
ralikio opened this issue Jan 14, 2025 · 0 comments
Open

Promote GA Pipeline - Ignore Whitespaces in Bump Check #1622

ralikio opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Comments

@ralikio
Copy link
Member

ralikio commented Jan 14, 2025

The following fragment of promote-keb-to-dev.yaml checks if version bump in management-plane-charts resulted in expected number of changes. However, the diff command used in the step outputs any whitespace modifications which fails the step in case of formatting changes.

- name: Check changes
working-directory: management-plane-charts
run: |
changes=$(git diff --shortstat)
echo "$changes"
if [[ "$changes" != *"3 insertions(+), 3 deletions(-)"* ]]; then
echo "Expected 3 insertions and 3 deletions, but found different changes."
exit 1
fi

Consider usage of ignore-all-space flag in this step.

@ralikio ralikio assigned ralikio and unassigned ralikio Jan 14, 2025
@PK85 PK85 added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2025
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

3 participants