Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SB: Validate OSB Api Compliance - Test Creation #1352

Closed
8 tasks done
ralikio opened this issue Oct 17, 2024 · 2 comments
Closed
8 tasks done

SB: Validate OSB Api Compliance - Test Creation #1352

ralikio opened this issue Oct 17, 2024 · 2 comments
Assignees

Comments

@ralikio
Copy link
Member

ralikio commented Oct 17, 2024

Create a test for OSB Api Compliance especially to check if all error codes are correct.

AC

  • check headers, query parameter, body
  • check for every endpoint

AC from #284 - #284 (comment) - KEB bindings responses details:

  • 1) we return 201 when BindingID was not existing, and was created with success
  • 2) we return 200 when BindingID WAS already existing, input parameters are the same and was created with success (in_progress,error is not success)
  • 3) we return 400 when invalid input params provided [JP - question - including not existent InstanceID?] [MM - non existing instanceID = 404]
  • 4) we return 409 when BindingID already exists but input params different
  • 5) we return 500 if KEB itself is not able to finalize binding creation
  • 6) we return 200 on DELETE when bindings exists, [JP - question - 410 when does not exists? - it seems that DELETE is not supposed to be idempotent] [MM - OSB says 410 if not exists]
@MarekMichali
Copy link
Contributor

MarekMichali commented Oct 17, 2024

Scenario:

  • user creates a binding with id x
  • binding x expires
  • user wants to create binding x again. The previous one with the same id is expired, but is still in the database

From meeting 17.09.2024: We decided to return 400 if the expired binding is still in the DB, and create a new binding if previous incarnation of binding (expired) is already removed by the cleaner job.

@ralikio
Copy link
Member Author

ralikio commented Oct 18, 2024

Further AC from "Contract between Provisioning Service and KEB bindings:" from #284 (comment):

Contract between Provisioning Service and KEB bindings:

  • 1) KEB bindings returns 201 or 200 if everything ok, then Provisioning Service persist binding on their side
  • 2) KEB bindings returns 400, 409, 500 if something wrong happen and then Provisioning Service DO NOT persist binding on their side, just pass error to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants