Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for Runtime CRs created via KEB and that are available as samples #244

Closed
3 tasks
Tracked by #112
Disper opened this issue May 31, 2024 · 2 comments
Closed
3 tasks
Tracked by #112

Add validation for Runtime CRs created via KEB and that are available as samples #244

Disper opened this issue May 31, 2024 · 2 comments

Comments

@Disper
Copy link
Member

Disper commented May 31, 2024 •
edited
Loading

Why
Runtime CRs has to have a valid values, otherwise invalid clusters might be created.

Should cover scenarios

  • Provisioning
  • Upgrade

What has to be validated

  • ensure that required values are non-empty (verify whole CRD, each field)

Note
Idea to start by adding that as a part of the state machine, then validation webhook could be considered.
@Disper Disper mentioned this issue May 31, 2024
Open
70 tasks
@Disper Disper changed the title Add validation for Runtime CRs created via KEB and that are available as samples (@m00g3n's idea) Add validation for Runtime CRs created via KEB and that are available as samples May 31, 2024
@tobiscr
Copy link
Contributor

tobiscr commented Dec 5, 2024 •
edited
Loading

Duplicate of #229 ??

@tobiscr tobiscr marked this as a duplicate of #229 Dec 5, 2024
@tobiscr
Copy link
Contributor

tobiscr commented Dec 5, 2024

closing as duplicate - we will continue in #229

@tobiscr tobiscr closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Disper @tobiscr