From 31ff8eb5e8af5034b9b55299486db178f4ec39d9 Mon Sep 17 00:00:00 2001
From: mrCherry97 <mwisnia97@gmail.com>
Date: Tue, 19 Nov 2024 10:28:34 +0100
Subject: [PATCH] fix: objectPageHeader styling and modules card

---
 .../DynamicPageComponent.scss                 |  3 +--
 .../ResourceCreate/ResourceCreate.js          |  2 +-
 .../ResourceDetails/ResourceDetails.scss      |  4 ++--
 .../components/ResourcesList/ResourcesList.js | 19 ++++++++++++++++---
 4 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/src/shared/components/DynamicPageComponent/DynamicPageComponent.scss b/src/shared/components/DynamicPageComponent/DynamicPageComponent.scss
index 1ba2f61fac..1d512b03ed 100644
--- a/src/shared/components/DynamicPageComponent/DynamicPageComponent.scss
+++ b/src/shared/components/DynamicPageComponent/DynamicPageComponent.scss
@@ -99,8 +99,7 @@
   }
 }
 
-ui5-button[data-component-name='ObjectPageAnchorBarExpandBtn'],
-div[data-component-name='ObjectPageHeaderContainer'] {
+ui5-button[data-component-name='ObjectPageAnchorBarExpandBtn'] {
   display: none;
 }
 
diff --git a/src/shared/components/ResourceCreate/ResourceCreate.js b/src/shared/components/ResourceCreate/ResourceCreate.js
index ed50fe5c0c..c62fe96473 100644
--- a/src/shared/components/ResourceCreate/ResourceCreate.js
+++ b/src/shared/components/ResourceCreate/ResourceCreate.js
@@ -221,7 +221,7 @@ export const ResourceCreate = ({
 };
 
 ResourceCreate.propTypes = {
-  performRefetch: PropTypes.func.isRequired,
+  performRefetch: PropTypes.func,
   title: PropTypes.string.isRequired,
   renderForm: PropTypes.func.isRequired,
   confirmText: PropTypes.string,
diff --git a/src/shared/components/ResourceDetails/ResourceDetails.scss b/src/shared/components/ResourceDetails/ResourceDetails.scss
index 244d4f803f..71aa69c029 100644
--- a/src/shared/components/ResourceDetails/ResourceDetails.scss
+++ b/src/shared/components/ResourceDetails/ResourceDetails.scss
@@ -24,7 +24,7 @@
   min-width: 200px;
 }
 
-@container (min-width: 650px) {
+@media (min-width: 650px) {
   .cluster-overview__details-wrapper {
     grid-template-columns: fit-content(100%) max-content;
   }
@@ -39,7 +39,7 @@
   }
 }
 
-@container (min-width: 900px) {
+@media (min-width: 900px) {
   .resource-details-container {
     grid-template-columns: fit-content(100%) max-content;
     gap: 0;
diff --git a/src/shared/components/ResourcesList/ResourcesList.js b/src/shared/components/ResourcesList/ResourcesList.js
index 2280842e21..77486ad7c7 100644
--- a/src/shared/components/ResourcesList/ResourcesList.js
+++ b/src/shared/components/ResourcesList/ResourcesList.js
@@ -92,6 +92,19 @@ export function ResourcesList({
     return <></>; // wait for the context update
   }
 
+  const allProps = {
+    customHeaderActions,
+    resourceUrl,
+    resourceType,
+    resourceTitle,
+    isCompact,
+    description,
+    layoutNumber,
+    resources,
+    filterFn,
+    ...props,
+  };
+
   const content = (
     <>
       <BannerCarousel
@@ -106,10 +119,10 @@ export function ResourcesList({
       {resources ? (
         <ResourceListRenderer
           resources={(resources || []).filter(filterFn)}
-          {...props}
+          {...allProps}
         />
       ) : (
-        <Resources {...props} />
+        <Resources {...allProps} />
       )}
     </>
   );
@@ -169,9 +182,9 @@ function Resources(props) {
     <ResourceListRenderer
       loading={loading}
       error={error}
-      resources={filter ? (resources || []).filter(filter) : resources || []}
       silentRefetch={silentRefetch}
       {...props}
+      resources={filter ? (resources || []).filter(filter) : resources || []}
     />
   );
 }