Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Module CR navigable on module list also in case of modules operated with customResourcePolicy: Ignore #3624

Closed
kwiatekus opened this issue Jan 22, 2025 · 1 comment · Fixed by #3676
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kwiatekus
Copy link
Contributor

Description

After adding docker-registry module with custom DockerRegistry CR via kyma cli (v3)
kyma@v3 alpha module add docker-registry -c experimental --some-custom-docker-registry.yaml
I end up having a running module, but I cannot see the status representing this fact on the module list (see attachment). The module CR is also not navigable as the link is not there in the first column.

This stems from the fact that such installation mode doesnt leave a reference to Module CR in the Kyma CR status. Such case adds the module with the customResourcePolicy: Ignore and user is entirely responsible for managing lifecycle of that Module CR

    - channel: experimental
      customResourcePolicy: Ignore
      managed: true
      name: docker-registry

In such case we could take the best effort approach and try to find the Module CR, render link and status badge.

Ideas

In theory kyma module operators should allow for one module CRs, so there should be one instance only.
Busola could read the type information of the module CR from the ModuleTemplate CR and lookup all instances and take the first one.

apiVersion: operator.kyma-project.io/v1beta2
kind: ModuleTemplate
...
  name: docker-registry-experimental
  namespace: kyma-system
...
spec:
  channel: experimental
  data:
    apiVersion: operator.kyma-project.io/v1alpha1
    kind: DockerRegistry

Reasons
Enabling kyma modules with custom Module CR from the beginning provides faster uptime for a module when comparing to enabling module with default CR and customising it post-installation. Adding the feature would improve user experience for such case and would make it consistent with experience users get when they enable modules with default module CR.

Attachments

Image

@mrCherry97 mrCherry97 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2025
@dbadura dbadura self-assigned this Feb 3, 2025
@pPrecel
Copy link
Contributor

pPrecel commented Feb 3, 2025

kyma@v3 alpha module add docker-registry -c experimental --some-custom-docker-registry.yaml

This command seems not to work. To reproduce the issue use:

curl 'https://raw.githubusercontent.com/kyma-project/docker-registry/refs/heads/main/config/samples/default-dockerregistry-cr.yaml' > /tmp/docker-registry.yaml
kyma@v3 alpha module add docker-registry -c experimental --cr-path /tmp/docker-registry.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants