Fix scrollToItem appearing underneath sticky header
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
approved these changes
Mar 12, 2021
When a `top` scroll position is used, the item will appear underneath the sticky section header. Now, we adjust the frame and use a manual content offset when sticky headers are enabled. When sticky headers are disabled or scrolling to a different position, we call the existing `scrollToItem` function on UICollectionView.
lokae0
force-pushed
the
fix-item-under-header
branch
from
6ca2e07 to
3c5bb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
topscroll position is used, the item will appear underneath the sticky section header.Now, we adjust the frame and use a manual content offset when sticky headers are enabled.
When sticky headers are disabled or scrolling to a different position, we call the existing
scrollToItemfunction on UICollectionView.Note this PR depends on the
performScrollToTargetFramefunction added in #277, so that one will need to be merged before this one builds.Example scrolling to Row # 50, 2:
Before:
After: