Actions #183
Actions #183
Conversation
| @@ -22,6 +22,8 @@ extension ListView | |||
|
|
|||
| func collectionView(_ collectionView: UICollectionView, shouldHighlightItemAt indexPath: IndexPath) -> Bool | |||
| { | |||
| guard view.behavior.selectionMode != .none else { return false } | |||
There was a problem hiding this comment.
Should set up some UI Tests for all this at some point...
| /// If the item is contained in the list, true is returned. If it is not, false is returned. | ||
| /// | ||
| @discardableResult | ||
| public func scrollTo<Content:ItemContent>(item : Identifier<Content>, position : ItemScrollPosition, animated : Bool = false) -> Bool |
There was a problem hiding this comment.
Dup of AnyIdentifier version
|
|
||
| guard let coordinator = coordinator else { | ||
| // No transition coordinator is available – we should just deselect return in this case. | ||
| item.set(isSelected: false, performCallbacks: true) |
There was a problem hiding this comment.
This is duped a couple places; consider unifying somewhere...
Listable/Sources/ListActions.swift
Outdated
| /// (for example, scrolling to a given item in the list) when used when you otherwise do | ||
| /// not have a reference to the underlying list view (for example, when using `ListViewController` or `BlueprintLists`). | ||
| /// | ||
| /// You also gain access to a `ListActions` instance when using `ListStateReader`, in each registered callback. |
There was a problem hiding this comment.
I have a little question about how to extract ListActions from ListStateReader given your example
list.stateReader = ListStateReader { reader in
reader.onDidScroll { info in
// Perform an action based on scrolling.
}
}Is the list action inside info?
There was a problem hiding this comment.
Oh I see, VisibilityChanged, DidScroll and ContentChanged all have list action.
There was a problem hiding this comment.
You can also provide your own in the view controller, like the list state view controller does: https://github.com/kyleve/Listable/pull/183/files#diff-b65540c265cdb28b73523231548845db
For a Blueprint list, it would be similar:
List { list in
...
list.actions = self.actions
}
| @@ -8,83 +8,205 @@ | |||
| import Foundation | |||
|
|
|||
|
|
|||
| /// | |||
|
|
||
| /// Example of how to use the `actions` within a reactive framwork like Combine or ReactiveSwift. | ||
|
|
||
| cancel = $index.sink { [weak self] value in |
There was a problem hiding this comment.
It looks like thru using reactive framework with the list actions, we can achieve auto scrolling on insert externally with ease. Does that mean the auto scroll API might have been redundant?
There was a problem hiding this comment.
Quite possibly; yeah – the auto-scroll is nice when you don't have conditional / signal based work to do, but yeah, might be nice to simplify the framework by pushing that requirement out to consumers.
There was a problem hiding this comment.
(Could probably even implement one in terms of the other, I bet)
There was a problem hiding this comment.
I am neutral on whether the auto scrolling API should stay. I think it is definitely convenient for some people. For me working in a workflow, I would lean towards having more explicit control on when the list should scroll.
|
Hey Kyle, let me know what is left to be done in this change, and when is the expected date for it to be merged. Thanks! |
|
Not a ton of stuff; need to apply the feedback here and then get the tests written. Hopefully landing this week (but it is hack week for us), but more likely Monday. |
kyleve
force-pushed
the
kve/list-state
branch
4 times, most recently
from
51d71be to
ff7c3bf
Compare
* origin/main: Opt out of layout if not vertical Additional self review and updates Self code review and tests for added code Remove LayoutDirection propagation from most APIs, implement rest of paged layout. Support keyboardAdjustmentMode, which allows for optionally not adjusting the content inset when a keyboard is visible
Introduces the concept of a
ListStateObserverandListActionsfor observing changes to a list, and for performing actions (currently only supported scrolling), respectively.See the ListStateViewController for an example of it in action.