-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System black theme #2592
Comments
If possible, detect if "amoled black" is enabled |
I was going to actually suggest this idea myself without seeing the other thread shortly. lol. Only thing I would suggest that would make it better is allow the user to select what color they want for both the "light" and "dark" modes of trail sense that will activate when set to "system color" mode. Different people may prefer a different color for "dark" mode from the current three modes night, dark, and black. I personally prefer black. For light mode white is okay for me but others may want a different color. This would probably be the best way to implement this and be an "be all end all" for this issue instead of selectively choosing the color based on if a device has an AMOLED screen which restricts everyone else who doesn't have an AMOLED screen from using this feature. (which may not be the easiest thing to detect). |
So maybe an entirely custom theme:
|
Also, for reference the AMOLED black detection wouldn't be me detecting if the device has AMOLED, but rather the system setting for using AMOLED black that was posted in the new feature thread. |
Perfect! Yes that system would work great (completely forgot the sunrise/sunset thing) and would allow both full customizability and future additions as well if others request different colors. |
Also, adding a trigger "static" or similar label so that the color doesn't change ever except for direct user input would be good to have as well if the user wants to change the theme manually. Almost completely forgot! |
I believe the static would just be the existing themes in Trail Sense, right? |
Yes, that would be correct |
Moving the custom theme over to this issue to keep this focused on just the system black theme: #2596 |
The same as the system theme, except it uses the black mode instead of dark.
The text was updated successfully, but these errors were encountered: