Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System black theme #2592

Closed
kylecorry31 opened this issue Oct 21, 2024 · 9 comments · Fixed by #2598
Closed

System black theme #2592

kylecorry31 opened this issue Oct 21, 2024 · 9 comments · Fixed by #2598
Labels
p4 Priority 4 theme
Milestone

Comments

@kylecorry31
Copy link
Owner

The same as the system theme, except it uses the black mode instead of dark.

@kylecorry31
Copy link
Owner Author

If possible, detect if "amoled black" is enabled

@7eventech77
Copy link

I was going to actually suggest this idea myself without seeing the other thread shortly. lol.

Only thing I would suggest that would make it better is allow the user to select what color they want for both the "light" and "dark" modes of trail sense that will activate when set to "system color" mode. Different people may prefer a different color for "dark" mode from the current three modes night, dark, and black. I personally prefer black. For light mode white is okay for me but others may want a different color. This would probably be the best way to implement this and be an "be all end all" for this issue instead of selectively choosing the color based on if a device has an AMOLED screen which restricts everyone else who doesn't have an AMOLED screen from using this feature. (which may not be the easiest thing to detect).

@kylecorry31
Copy link
Owner Author

I was going to actually suggest this idea myself without seeing the other thread shortly. lol.

Only thing I would suggest that would make it better is allow the user to select what color they want for both the "light" and "dark" modes of trail sense that will activate when set to "system color" mode. Different people may prefer a different color for "dark" mode from the current three modes night, dark, and black. I personally prefer black. For light mode white is okay for me but others may want a different color. This would probably be the best way to implement this and be an "be all end all" for this issue instead of selectively choosing the color based on if a device has an AMOLED screen which restricts everyone else who doesn't have an AMOLED screen from using this feature. (which may not be the easiest thing to detect).

So maybe an entirely custom theme:

  • Trigger (system, sunrise/sunset)
  • System light / sun up (user can choose dark, light, black, night)
  • System dark / sun down (user can choose dark, light, black, night)

@kylecorry31
Copy link
Owner Author

Also, for reference the AMOLED black detection wouldn't be me detecting if the device has AMOLED, but rather the system setting for using AMOLED black that was posted in the new feature thread.

@7eventech77
Copy link

7eventech77 commented Oct 22, 2024

I was going to actually suggest this idea myself without seeing the other thread shortly. lol.
Only thing I would suggest that would make it better is allow the user to select what color they want for both the "light" and "dark" modes of trail sense that will activate when set to "system color" mode. Different people may prefer a different color for "dark" mode from the current three modes night, dark, and black. I personally prefer black. For light mode white is okay for me but others may want a different color. This would probably be the best way to implement this and be an "be all end all" for this issue instead of selectively choosing the color based on if a device has an AMOLED screen which restricts everyone else who doesn't have an AMOLED screen from using this feature. (which may not be the easiest thing to detect).

So maybe an entirely custom theme:

  • Trigger (system, sunrise/sunset)
  • System light / sun up (user can choose dark, light, black, night)
  • System dark / sun down (user can choose dark, light, black, night)

Perfect! Yes that system would work great (completely forgot the sunrise/sunset thing) and would allow both full customizability and future additions as well if others request different colors.

@7eventech77
Copy link

Also, adding a trigger "static" or similar label so that the color doesn't change ever except for direct user input would be good to have as well if the user wants to change the theme manually. Almost completely forgot!

@kylecorry31
Copy link
Owner Author

Also, adding a trigger "static" or similar label so that the color doesn't change ever except for direct user input would be good to have as well if the user wants to change the theme manually. Almost completely forgot!

I believe the static would just be the existing themes in Trail Sense, right?

@7eventech77
Copy link

Also, adding a trigger "static" or similar label so that the color doesn't change ever except for direct user input would be good to have as well if the user wants to change the theme manually. Almost completely forgot!

I believe the static would just be the existing themes in Trail Sense, right?

Yes, that would be correct

@kylecorry31
Copy link
Owner Author

Moving the custom theme over to this issue to keep this focused on just the system black theme: #2596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4 Priority 4 theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants