-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduled close event for thread save to config vars #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing here
Known issue: channel will still close when the bot is down
kyb3r
requested changes
Jan 17, 2019
kyb3r
reviewed
Jan 17, 2019
kyb3r
reviewed
Jan 17, 2019
kyb3r
reviewed
Jan 17, 2019
kyb3r
reviewed
Jan 17, 2019
kyb3r
reviewed
Jan 17, 2019
kyb3r
approved these changes
Jan 17, 2019
Update changelog, increment minor patch version, and then I will merge. |
Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Automatic dyno restarts, all dynos will restart at least once every 27 hours.
During this period, local caches are deleted, which results in the inability to set the scheduled closure time to longer than 24 hours.
This PR resolves this issue.
Fixes #134
call_later()
instead ofsleep()
for scheduling.closures
.closures
upon startclosures['id']
upon deletionFormat:
recipient_id
(str) the id of the recipient, akathread.id
.time
(str) an 'ISO 8601 formatted datetime string.closer_id
(int) the user who initiated the closure of the thread.The following are the same as the parameters of the
close()
function.silent
(bool)delete_channel
(bool)message
(str)Unresolved Known Issues
Aside
#Addresses #133
Please carefully review this PR and minor version bump upon approval.