Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionBase.changed_entities fails without TransactionChanges plugin #85

Open
kandarz opened this issue Dec 12, 2014 · 1 comment
Open

Comments

@kandarz
Copy link

kandarz commented Dec 12, 2014

I'm upgrading from v1.0b5 to 1.1.4 and I encountered that TransactionBase.changed_entities breaks when not using TransactionChanges plugin which I'm not as it wasn't required before.

Commenting out lines 50-51 in 1.1.4 allows continued use as before.

if class_.__name__ not in self.entity_names:
    continue

As it's the self.changes property that doesn't exist:

@property
def entity_names(self):
    """
    Return a list of entity names that changed during this transaction.
    """
    return [changes.entity_name for changes in self.changes]

As far as I can tell, the TransactionChanges portion is just to not query the DB if its already known no entities were changed.

Is this something that can be changed?

@TomGoBravo
Copy link
Contributor

#268 addresses this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants