Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail validation faster if the image doesn't exist for the right platform #763

Closed
h4ck3rk3y opened this issue Jun 23, 2023 · 1 comment · Fixed by #814
Closed

fail validation faster if the image doesn't exist for the right platform #763

h4ck3rk3y opened this issue Jun 23, 2023 · 1 comment · Fixed by #814
Assignees
Labels
bug Something isn't working painful Painful bug

Comments

@h4ck3rk3y
Copy link
Contributor

What's your CLI version?

0.79.0

Description & steps to reproduce

MOCK_MEV_IMAGE = "ethpandaops/mock-builder:latest"
MOCK_MEV_SERVICE_NAME = "mock-mev"

def run(plan, args):
launch_mock_mev(plan, "foo", "bar", "doo")

def launch_mock_mev(plan, el_uri, beacon_uri, jwt_secret):
plan.add_service(
name = MOCK_MEV_SERVICE_NAME,
config = ServiceConfig(
image = MOCK_MEV_IMAGE,
ports = {
"rest": PortSpec(number = 18550, transport_protocol="TCP"),
},
cmd = [
"--jwt-secret={0}".format(jwt_secret),
"--el={0}".format(el_uri),
"--beacon={0}".format(beacon_uri)
]
)
)



### Desired behavior


 "ethpandaops/mock-builder:latest" doesn't have arm64 and validation still passes but the execution fails which is confusing. either we override and download despite arch or we fail in validation itself


### What is the severity of this bug?

Painful; this is causing significant friction in my workflow.
@h4ck3rk3y h4ck3rk3y added the bug Something isn't working label Jun 23, 2023
@github-actions github-actions bot added the painful Painful bug label Jun 23, 2023
@h4ck3rk3y
Copy link
Contributor Author

Pari from Ethereum ran into this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working painful Painful bug
Projects
None yet
1 participant