fix: make releases work again without v in tags #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasbusa
approved these changes
Nov 1, 2024
This was referenced Nov 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
🤖 I have created a release *beep* *boop* --- ## [1.4.2](v1.4.1...1.4.2) (2024-11-10) ### Bug Fixes * don't include component name in release please tags ([#2590](#2590)) ([28582cc](28582cc)) * make releases work again without v in tags ([#2586](#2586)) ([a87f945](a87f945)) * remove closeChannelWhenEmpty busy loop ([#2594](#2594)) ([dbb2193](dbb2193)) * wrong config structure for release please ([#2588](#2588)) ([e7263c3](e7263c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The release please config was put into the manifest file. That should not be the case. The config file is a separate file. That's why the config wasn't read and we ended up having the
vprefix in the most recent 1.4.1 release.More infos https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#bootstrap-manually
REMINDER: Tag Reviewers, so they get notified to review
Is this change user facing?
NO
References (if applicable)