Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make dev/tools doesn't install clang-format #2441

Closed
lahabana opened this issue Jul 27, 2021 · 6 comments · Fixed by #4960
Closed

make dev/tools doesn't install clang-format #2441

lahabana opened this issue Jul 27, 2021 · 6 comments · Fixed by #4960
Labels
area/ci-cd triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Jul 27, 2021 •
edited by michaelbeaumont
Loading

This ignores clang-format when running make check locally and clang-format is not installed.
This is frustrating for the dev as they only discover in CI that the protobufs are not correctly formatted.

Another option is to use a more complete, protobuf specific tool like https://github.com/bufbuild/buf
@lahabana lahabana added the ci label Jul 27, 2021
@lahabana lahabana added area/ci-cd and removed ci labels Nov 22, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 25, 2021
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/stale Inactive for some time. It will be triaged again labels Apr 26, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 27, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jun 27, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 29, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@michaelbeaumont
Copy link
Contributor

Another option is to use a more complete, protobuf specific tool like https://github.com/bufbuild/buf

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Jul 29, 2022
@lahabana
Copy link
Contributor Author

I'm curious to see if we could switch to buf completely for protobuf gen.

@lahabana lahabana mentioned this issue Sep 2, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci-cd triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: rewrite make dev/tools lahabana/kuma
2 participants
@lahabana @michaelbeaumont