Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with 0.7/1.0 #47

Closed
13 tasks done
lostella opened this issue Nov 27, 2017 · 2 comments
Closed
13 tasks done

Compatibility with 0.7/1.0 #47

lostella opened this issue Nov 27, 2017 · 2 comments

Comments

@lostella
Copy link
Member

lostella commented Nov 27, 2017

Currently tests fail on nightly. Since feature freeze for Julia 1.0 is about to hit, it will be soon time to start making the package forward-compatible. We can use this space to list criticalities and discussions on that regards.

Update - 25/03/2018

I'm currently going through this. General things found so far:

  • the Base.LinAlg module is now LinearAlgebra
  • Base.A_mul_B! has become LinearAlgebra.mul!
  • Base.Ac_mul_B!(y, A, x) is now LinearAlgebra.mul!(y, adjoint(A), x)
  • sparse factorizations moved to the SuiteSparse module (from Base.SparseArrays)
  • random number generation functions moved to the Random module (from Base)
  • @printf moved to the Printf module (from Base)
  • warnings are generated when .+ (and similarly for other operators) is not appropriately spaced away from the operands (example: 2.+x confuses the parser on the nature of first summand 2 or 2.0 I guess)
  • when broadcast was not explicitly used, e.g. x::AbstractArray + y::Number, now we get a warning
  • zeros(a::AbstractArray) is deprecated in favor of zero, fill, fill!
  • the old form function f{T}(x::T) ... end now generates warnings, I'm getting rid of these everywhere, in favor of the where notation
  • docstrings should be 1 newline away from what they refer to (i.e., no blank line in between, warning otherwise)
  • findmax does not work on generator expressions anymore

Package specific issues:

  • dspev! and dspevV! are broken
@lostella
Copy link
Member Author

@nantonel
Copy link
Collaborator

This list is very useful! Thanks for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants