You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently tests fail on nightly. Since feature freeze for Julia 1.0 is about to hit, it will be soon time to start making the package forward-compatible. We can use this space to list criticalities and discussions on that regards.
Update - 25/03/2018
I'm currently going through this. General things found so far:
the Base.LinAlg module is now LinearAlgebra
Base.A_mul_B! has become LinearAlgebra.mul!
Base.Ac_mul_B!(y, A, x) is now LinearAlgebra.mul!(y, adjoint(A), x)
sparse factorizations moved to the SuiteSparse module (from Base.SparseArrays)
random number generation functions moved to the Random module (from Base)
@printf moved to the Printf module (from Base)
warnings are generated when .+ (and similarly for other operators) is not appropriately spaced away from the operands (example: 2.+x confuses the parser on the nature of first summand 2 or 2.0 I guess)
when broadcast was not explicitly used, e.g. x::AbstractArray + y::Number, now we get a warning
zeros(a::AbstractArray) is deprecated in favor of zero, fill, fill!
the old form function f{T}(x::T) ... end now generates warnings, I'm getting rid of these everywhere, in favor of the where notation
docstrings should be 1 newline away from what they refer to (i.e., no blank line in between, warning otherwise)
findmax does not work on generator expressions anymore
Package specific issues:
dspev! and dspevV! are broken
The text was updated successfully, but these errors were encountered:
Currently tests fail on nightly. Since feature freeze for Julia 1.0 is about to hit, it will be soon time to start making the package forward-compatible. We can use this space to list criticalities and discussions on that regards.
Update - 25/03/2018
I'm currently going through this. General things found so far:
Base.LinAlg
module is nowLinearAlgebra
Base.A_mul_B!
has becomeLinearAlgebra.mul!
Base.Ac_mul_B!(y, A, x)
is nowLinearAlgebra.mul!(y, adjoint(A), x)
SuiteSparse
module (fromBase.SparseArrays
)Random
module (fromBase
)@printf
moved to thePrintf
module (fromBase
).+
(and similarly for other operators) is not appropriately spaced away from the operands (example:2.+x
confuses the parser on the nature of first summand2
or2.0
I guess)x::AbstractArray + y::Number
, now we get a warningzeros(a::AbstractArray)
is deprecated in favor ofzero
,fill
,fill!
function f{T}(x::T) ... end
now generates warnings, I'm getting rid of these everywhere, in favor of thewhere
notationfindmax
does not work on generator expressions anymorePackage specific issues:
dspev!
anddspevV!
are brokenThe text was updated successfully, but these errors were encountered: