Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't update to Angular 18 #555

Closed
Talb2005 opened this issue May 26, 2024 · 5 comments · Fixed by #568
Closed

Can't update to Angular 18 #555

Talb2005 opened this issue May 26, 2024 · 5 comments · Fixed by #568
Labels
dependencies Pull requests that update a dependency file enhancement pr-welcome

Comments

@Talb2005
Copy link
Contributor

Executing ng update @angular/cdk @angular/material results in:

Package "@mat-datetimepicker/core" has an incompatible peer dependency to "@angular/cdk" (requires "^17.0.0", would install "18.0.0").
Package "@mat-datetimepicker/core" has an incompatible peer dependency to "@angular/material" (requires "^17.0.0", would install "18.0.0").
@bbortt
Copy link
Collaborator

bbortt commented May 27, 2024

someone would have to upgrade the repo (especially peerDependencies) first.

@bbortt bbortt added enhancement pr-welcome dependencies Pull requests that update a dependency file labels May 27, 2024
@bbortt bbortt mentioned this issue May 30, 2024
Closed
@Talb2005
Copy link
Contributor Author

I have created a PR. #563
Please review it.

@Talb2005 Talb2005 mentioned this issue Jun 17, 2024
Closed
@bbortt
Copy link
Collaborator

bbortt commented Jun 19, 2024

will do, many thanks!

@Negodyaj
Copy link

I'm sorry, but any ETA on this?...)

@bbortt bbortt mentioned this issue Jun 25, 2024
Merged
@Negodyaj
Copy link

thanks so much!! )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement pr-welcome
Projects
None yet
Milestone
No milestone
3 participants
@bbortt @Negodyaj @Talb2005