Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readiness probe endpoint and /audit, /validate share the same default port #1117

Open
5 tasks
viccuad opened this issue Mar 4, 2025 · 2 comments
Open
5 tasks

Comments

@viccuad
Copy link
Member

viccuad commented Mar 4, 2025

Readiness probe port (--readiness-probe-port) and the normal port (--port) both default to 3000.

Given that we have --port 3000 everywhere in docs, audit-scanner, etc, change --readiness-probe-port.

Acceptance criteria

  • Change the default port (--readiness-probe-port) in policy-server to 8081 (same as /healthz, /readyz of controller)
  • Update policy-server cli-docs.md
  • Make sure ports are correctly exposed in policy-server Dockerfile
  • Update docs/reference/policy-server-cli.md
  • Check policy-server deployment reconciler on the controller and add probes if needed
@flavio
Copy link
Member

flavio commented Mar 4, 2025

While we're at that... can we configure the Policy Server's Service objects to expose these ports on the "standard" ones?

Meaning:

  • 8080 -> 80
  • 8443 -> 443

@flavio flavio moved this to Todo in Kubewarden Mar 4, 2025
@flavio flavio added this to the 1.23 milestone Mar 4, 2025
@viccuad
Copy link
Member Author

viccuad commented Mar 4, 2025

That's indeed better. With that change the card needs to be rewritten, there's quite the notions of port 3000 on docs, development deployment tools, etc (see search).

@flavio flavio moved this from Todo to In Progress in Kubewarden Mar 4, 2025
@flavio flavio self-assigned this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants