Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add latest tag when no tag is present #156

Conversation

fabriziosestito
Copy link
Contributor

@fabriziosestito fabriziosestito commented Sep 11, 2023

Description

Resolves: kubewarden/kwctl#554

Adds :latest to the destination filename if no tag is present.

Test

Will test in kwctl e2e tests

Additional Information

@fabriziosestito fabriziosestito self-assigned this Sep 11, 2023
@fabriziosestito fabriziosestito requested a review from a team as a code owner September 11, 2023 06:53
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, it would be nice to have this fix released as part of kubewarden 1.7 release

@fabriziosestito fabriziosestito merged commit c6c40fe into kubewarden:main Sep 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Pull from registry without the :latest tag causes the final policy to not have a tag
2 participants