Ginkgo custom reporters are deprecated and should be removed from functest #506

lyarwood · 2023-02-21T18:50:09Z

/kind bug

What happened:

The following output is after applying #505 but has been around since we moved to v2 a while ago:

$ make functest
[..]
You're using deprecated Ginkgo functionality:
=============================================
  Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.8.3

The code in question being:

ssp-operator/tests/tests_suite_test.go

Lines 567 to 575 in 9afb074

    
           var reporters []Reporter 
        
           if qe_reporters.JunitOutput != "" { 
        
           	reporters = append(reporters, ginkgo_reporters.NewJUnitReporter(qe_reporters.JunitOutput)) 
        
           } 
        
           if qe_reporters.Polarion.Run { 
        
           	reporters = append(reporters, &qe_reporters.Polarion) 
        
           }

Hopefully we can just remove this but I thought I'd write it up as a bug first.

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
SSP Operator version:
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

The text was updated successfully, but these errors were encountered:

RoniKishner · 2023-02-21T19:01:52Z

We should make an effort to keep the Polarion reports, they help us keep track of issues.
hopefully it's not much work following the guide on - https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

In theory we need to swap RunSpecsWithDefaultAndCustomReporters and RunSpecsWithCustomReporters with RunSpecs, and the CI should use the needed flag.

lyarwood · 2023-02-21T19:23:28Z

I don't think it's that easy as there's also the custom PolarionReporter to consider that means you would need to...

If you've written your own custom reporter, [add a ReportAfterSuite node]
(https://onsi.github.io/ginkgo/MIGRATING_TO_V2#generating-custom-reports-when-a-test-suite-completes) and process 
the types.Report that it provides you. If you'd like to continue using your custom reporter you can simply call 
reporters.ReportViaDeprecatedReporter(reporter, report) in ReportAfterSuite - though we recommend actually changing 
your code's logic to use the types.Report object directly as reporters.ReportViaDeprecatedReporter will be removed in a 
future release of Ginkgo 2.X. Unlike 1.X custom reporters which are called concurrently by independent parallel 
processes when running in parallel, ReportAFterSuite is called exactly once per suite and is guaranteed to have 
aggregated information from all parallel processes.

kubevirt-bot · 2023-05-22T19:54:05Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.