Investigate if it is ok that ServiceMonitor is deployed with TLS disabled

[akrejcir]

The ServiceMonitor created by the metrics operand defines an endpoint with disabled TLS.

ssp-operator/internal/operands/metrics/resources.go

Lines 63 to 93 in 4fd4022

	func newServiceMonitorCR(namespace string) *promv1.ServiceMonitor {
	return &promv1.ServiceMonitor{
	ObjectMeta: metav1.ObjectMeta{
	Namespace: namespace,
	Name: rules.RuleName,
	Labels: ServiceMonitorLabels(),
	},
	Spec: promv1.ServiceMonitorSpec{
	NamespaceSelector: promv1.NamespaceSelector{
	Any: true,
	},
	Selector: metav1.LabelSelector{
	MatchLabels: map[string]string{
	PrometheusLabelKey: PrometheusLabelValue,
	},
	},
	Endpoints: []promv1.Endpoint{
	{
	Port: MetricsPortName,
	Scheme: "https",
	TLSConfig: &promv1.TLSConfig{
	SafeTLSConfig: promv1.SafeTLSConfig{
	InsecureSkipVerify: true,
	},
	},
	HonorLabels: true,
	},
	},
	},
	}
	}

This issue is to investigate if it is intentional, and if there are any technical reasons why we cannot enable it.

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[akrejcir]

/remove-lifecycle stale