Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflicting subscription name with control plane #6042

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

exu
Copy link
Member

@exu exu commented Nov 19, 2024

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@exu exu requested a review from a team as a code owner November 19, 2024 21:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.66%. Comparing base (69dcd7f) to head (24ee2c1).
Report is 2274 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6042      +/-   ##
==========================================
- Coverage   25.80%   19.66%   -6.15%     
==========================================
  Files         198      576     +378     
  Lines       15240    57185   +41945     
==========================================
+ Hits         3933    11243    +7310     
- Misses      10917    44949   +34032     
- Partials      390      993     +603     
Flag Coverage Δ
integrationtests ?
unittests 19.66% <ø> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@exu exu merged commit 15ddfbe into main Nov 19, 2024
7 checks passed
@exu exu deleted the fix/conflicting-subscription-names branch November 19, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants