Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [TKC-2802] use custom callback port #6035

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: [TKC-2802] use custom callback port #6035

wants to merge 6 commits into from

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Nov 15, 2024 •
edited
Loading

Pull request description

  • support custom callback port
  • ise current callback port 8090 as default, switch to 38090 after propagation of dex changes

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@vsukhin
fix: use custom callback port
fd3d807 
Signed-off-by: Vladislav Sukhin <[email protected]>
@vsukhin vsukhin changed the title fix: use custom callback port fix: [TKC-2802] use custom callback port Nov 15, 2024
@vsukhin
Merge branch 'main' into vskhin/fix/callback-port
f9ce626 
Signed-off-by: Vladislav Sukhin <[email protected]>

# Conflicts:
#	cmd/kubectl-testkube/commands/common/helper.go
#	cmd/kubectl-testkube/commands/pro/init.go
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 19.65%. Comparing base (69dcd7f) to head (3fea1ba).
Report is 2272 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cloudlogin/login.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6035      +/-   ##
==========================================
- Coverage   25.80%   19.65%   -6.16%     
==========================================
  Files         198      576     +378     
  Lines       15240    57185   +41945     
==========================================
+ Hits         3933    11239    +7306     
- Misses      10917    44954   +34037     
- Partials      390      992     +602
Flag Coverage Δ
integrationtests ?
unittests 19.65% <0.00%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@vsukhin vsukhin marked this pull request as ready for review November 21, 2024 17:40
@vsukhin vsukhin requested a review from a team as a code owner November 21, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exu exu exu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsukhin @codecov-commenter @exu