Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge general-use steps properly #6031

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

rangoo94
Copy link
Member

Pull request description

  • It was incorrectly using default image when the container had pure operation merged forward
kind: TestWorkflow
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: example
spec:
  steps:
  - delay: 1s
    run:
      image: curlimages/curl:latest
      shell: curl -XGET http://testkube.io/

It will run both commands with the default init image, instead of curlimages/curl:latest

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner November 15, 2024 08:19
@rangoo94 rangoo94 merged commit b56671f into main Nov 15, 2024
21 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/merging-general-steps branch November 15, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants