fail Create() if object already exists #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthyx
force-pushed
the
alreadyexists
branch
from
a6e8f63
to
df5c866
Compare
|
Summary:
|
1 similar comment
|
Summary:
|
|
Summary:
|
matthyx
force-pushed
the
alreadyexists
branch
from
d52706a
to
e903df8
Compare
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
force-pushed
the
alreadyexists
branch
from
e903df8
to
d7aed14
Compare
|
Summary:
|
amirmalka
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while this aligns with regular api-server behavior, we should test all our components in case we don't expect Create() to fail