KUBESAW-170: Replace custom ksctl adm restart logic with the one from kubectl rollout #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kubectl rollout Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak,
mfrancisc,
drpaneas and
metlos
as code owners
| } | ||
| return true, nil | ||
| return kubectl.SetUpKubectlCmd(func(factory cmdutil.Factory, ioStreams genericclioptions.IOStreams) *cobra.Command { | ||
| return kubectlrollout.NewCmdRolloutRestart(factory, ioStreams) |
There was a problem hiding this comment.
as I mentioned in our call and also in the jira story, the command should also wait until the rollout is complete
Comment on lines
+73
to
+86
| kubeConfigFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag() | ||
| hFactory := cmdutil.NewFactory(cmdutil.NewMatchVersionFlags(kubeConfigFlags)) | ||
| ioStreams := genericclioptions.IOStreams{ | ||
| In: nil, // Not to forward the Standard Input | ||
| Out: os.Stdout, | ||
| ErrOut: os.Stderr, | ||
| } | ||
|
|
||
| hArgs := []string{"", "deployments", | ||
| "--namespace", hostConfig.OperatorNamespace, | ||
| "--server", hostConfig.ServerAPI, | ||
| "--token", hostConfig.Token} | ||
|
|
||
| o := kubectlrollout.NewRolloutRestartOptions(ioStreams) |
There was a problem hiding this comment.
this seem to be very similar to what we already have in base_kubectl.go, let's try to reuse the already existing code if possible.
and as I mentioned in the other comment, it would be nice to wait.
Comment on lines
+69
to
+70
| return restartHostOperator(hostClusterConfig) | ||
| } |
There was a problem hiding this comment.
btw, have you considered using PostRun field?
|
closing in favour of #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace the custom ksctl adm restart logic with the one from "kubectl rollout" command, so that there is no down-time that was introduced by the current custom logic.