Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make baseUrl configurable for Github #610

Open
mms-gianni opened this issue Jan 22, 2025 · 0 comments · Fixed by #611 or #618
Open

Make baseUrl configurable for Github #610

mms-gianni opened this issue Jan 22, 2025 · 0 comments · Fixed by #611 or #618
Labels
Idea/discussion

Comments

@mms-gianni
Copy link
Member

Description

Github Enterprise has the possibility to run it under a custom URL.

Possible solution

OctoKit has a baseUrl field which should be configurable. Default should be github.com

https://github.com/octokit/octokit.js/blob/main/README.md

https://github.com/kubero-dev/kubero/blob/main/server/src/git/github.ts#L15

Alternatives

Additional information

No response
@mms-gianni mms-gianni linked a pull request Jan 22, 2025 that will close this issue
Update GithubApi constructor to include baseUrl parameter and set de… #611
Merged
12 tasks
@mms-gianni mms-gianni linked a pull request Jan 31, 2025 that will close this issue
modified views and checks for GitHub BaseUrl usage #618
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Idea/discussion
Projects
None yet
Milestone
No milestone
1 participant
@mms-gianni