Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update federation control plane turn down command #7332

Merged
merged 1 commit into from
Feb 18, 2018
Merged

update federation control plane turn down command #7332

merged 1 commit into from
Feb 18, 2018

Conversation

c6h3un
Copy link
Contributor

@c6h3un c6h3un commented Feb 9, 2018 •
edited by k8s-reviewable
Loading

kubectl uses --context option for specifying the context, the option --host-cluster-context is for kubefed join.

Allow edits from maintainers checkbox

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 9, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 9, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3615f3d

https://deploy-preview-7332--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Feb 10, 2018

@c6h3un need check why the CLA validation failed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 10, 2018
@c6h3un
Copy link
Contributor Author

c6h3un commented Feb 10, 2018

@tengqm Sorry that I pushed with wrong name and email before, I removed those commits.

@c6h3un
update federation control plane turn down command
3615f3d 
**kubectl** uses `--context` option for specifying the context, the option `--host-cluster-context` is for **kubefed join**.
tengqm
tengqm approved these changes Feb 11, 2018
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2018
@heckj
Copy link
Contributor

heckj commented Feb 18, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit 246cb9e into kubernetes:master Feb 18, 2018
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
@c6h3un @bsalamat
update federation control plane turn down command (kubernetes#7332)
684ace6 
**kubectl** uses `--context` option for specifying the context, the option `--host-cluster-context` is for **kubefed join**.
tehut pushed a commit to tehut/website that referenced this pull request Mar 8, 2018
@c6h3un @tehut
update federation control plane turn down command (kubernetes#7332)
92ed52b 
**kubectl** uses `--context` option for specifying the context, the option `--host-cluster-context` is for **kubefed join**.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm approved these changes

@bradtopol bradtopol Awaiting requested review from bradtopol

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c6h3un @k8s-ci-robot @k8sio-netlify-preview-bot @tengqm @heckj