-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify image change restart behavior for sidecar containers #47024
base: main
Are you sure you want to change the base?
Clarify image change restart behavior for sidecar containers #47024
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
eb9659d
to
6f8395e
Compare
@sftim included your comments |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dshebib Please help resolve the conflicts. |
Clarify that only chaging the image of a sidecar container will not restart the pod.
Previously had contradicting information:
Altering an init container image field is equivalent to restarting the Pod.
and
The Pod will not be restarted when the init container image is changed,
xref: kubernetes/kubernetes#121333