-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tabs by spaces in glossary-terms partials #15408
Replace tabs by spaces in glossary-terms partials #15408
Conversation
Using tabs in this partials seems to cause Hugo to parse the partial as a code block instead of rendering the HTML code. Solves kubernetes#14792 rendering issues.
@raelga: GitHub didn't allow me to request PR reviews from the following users: bep. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @raelga can you give me a reference why i should use spaces instead of tabs |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 9458a48 https://deploy-preview-15408--kubernetes-io-master-staging.netlify.com |
/assign @steveperry-53 |
I'm not really sure why but looks like Hugo, while parsing the HTML partial reads the tabs, interprets the resulting Markdown as a code block and encapsulates it between a
<p><a class='glossary-tooltip' href='/docs/concepts/workloads/pods/pod-overview/' target='_blank'>Pod<span class='tooltip-text'>Unit Kubernetes yang paling sederhana dan kecil. Sebuah Pod merepresentasikan sebuah set kontainer yang dijalankan pada kluster kamu.</span> Maybe is related to gohugoio/hugo#4717. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using tabs in this html-partial used in the glossary-tooltip shortcode seems to cause Hugo to parse the shortcode as a
<pre><code>
block instead of rendering the resulting HTML code.Solves #14792 rendering issues:
/cc @bep @zacharysarah @irvifa @sftim @girikuncoro