Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential edit for k8s.io/docs/concepts/services-networking/dual-stack/ #49773

Open
jmuthalaly opened this issue Feb 16, 2025 · 6 comments · May be fixed by #49821
Open

Potential edit for k8s.io/docs/concepts/services-networking/dual-stack/ #49773

jmuthalaly opened this issue Feb 16, 2025 · 6 comments · May be fixed by #49821
Assignees
@priyanshsao
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@jmuthalaly
Copy link

For #3 under Dual-stack options on new Services, should the last mention of spec.clusterIPs instead say spec.ipFamilies?

Current:
This Service specification explicitly defines IPv6 and IPv4 in .spec.ipFamilies as well as defining PreferDualStack in .spec.ipFamilyPolicy. When Kubernetes assigns an IPv6 and IPv4 address in .spec.clusterIPs, .spec.clusterIP is set to the IPv6 address because that is the first element in the .spec.clusterIPs array, overriding the default.

Potential edit:
This Service specification explicitly defines IPv6 and IPv4 in .spec.ipFamilies as well as defining PreferDualStack in .spec.ipFamilyPolicy. When Kubernetes assigns an IPv6 and IPv4 address in .spec.clusterIPs, .spec.clusterIP is set to the IPv6 address because that is the first element in the .spec.ipFamilies array, overriding the default.
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 16, 2025
@priyanshsao
Copy link

/sig docs
/language en

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language labels Feb 16, 2025
@utkarsh-singh1
Copy link
Contributor

Does not seem to have any changes visible to me, can you suggest words or specific sentences that are needed in change.

@sftim
Copy link
Contributor

sftim commented Feb 16, 2025

/sig network

Seems right. See the bold text in the issue description to understand the proposed change.

/language en
/triage accepted
Pull requests welcome!
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 16, 2025
@priyanshsao
Copy link

/assign

@utkarsh-singh1
Copy link
Contributor

Seems right. See the bold text in the issue description to understand the proposed change.

Oh my mistake, Thanks @sftim for the clearence.

priyanshsao added a commit to priyanshsao/website that referenced this issue Feb 18, 2025
@priyanshsao
Merge branch 'kubernetes:main' into issue-kubernetes#49773
66d8be9
@priyanshsao priyanshsao linked a pull request Feb 18, 2025 that will close this issue
Open
@sftim
Copy link
Contributor

sftim commented Feb 18, 2025

I've changed my mind; I now don't see evidence that we should make this change.
/remove-triage accepted
/remove-priority backlog
/priority awaiting-more-evidence

@k8s-ci-robot k8s-ci-robot added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priyanshsao priyanshsao

Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong field name in dual-stack networking page priyanshsao/website
5 participants
@jmuthalaly @k8s-ci-robot @sftim @utkarsh-singh1 @priyanshsao