Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SidecarContainer] Need to provide sidecar implementation best practices #47823

Closed
SergeyKanzhelev opened this issue Sep 6, 2024 · 4 comments · Fixed by #48228
Closed

[SidecarContainer] Need to provide sidecar implementation best practices #47823

SergeyKanzhelev opened this issue Sep 6, 2024 · 4 comments · Fixed by #48228
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@SergeyKanzhelev
Copy link
Member

This is a follow up from kubernetes/enhancements#753 (comment)

We need to improve the page https://kubernetes.io/docs/tutorials/configuration/pod-sidecar-containers/ with the best practices on how to implement sidecar containers. Things like exiting with 0 on SIGTERM

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 6, 2024
@SergeyKanzhelev
Copy link
Member Author

/sig node
/kind feature

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 6, 2024
@sftim
Copy link
Contributor

sftim commented Sep 7, 2024

/priority backlog
/language en
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2024
@pegasas
Copy link
Contributor

pegasas commented Sep 8, 2024

/assign @pegasas

@SergeyKanzhelev
Copy link
Member Author

Some interesting issues that we need to cover:

  1. If a sidecar never had a chance to execute the startup probe, it will prevent the main container from even starting: SideCar startupProbe on 1.28 kubernetes#120848
  2. Sidecar implemented as a built-in type always starts before the container. So it will block the main container start before the sidecar's image is pulled. See [Sidecar Containers] Ability to start sidecar and main containers in parallel kubernetes#126471 The best practice here is to postpone all heavy operations to as late as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants