Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-graceful node shutdown section from concepts/architecture/nodes.md to concepts/cluster-administration #45690

Closed
reylejano opened this issue Mar 26, 2024 · 6 comments · Fixed by #45996
Closed

Move non-graceful node shutdown section from concepts/architecture/nodes.md to concepts/cluster-administration #45690

reylejano opened this issue Mar 26, 2024 · 6 comments · Fixed by #45996
Assignees
@mrgiles
Labels
language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@reylejano
Copy link
Member

reylejano commented Mar 26, 2024 •
edited
Loading

Since concepts/architecture/nodes.md is a page better suited for those learning Kubernetes, the non-graceful node shutdown section, graceful node shutdown section and forced storage detach on timeout section is better suited to be on the concepts/cluster-administration page
See comment thread: https://github.com/kubernetes/website/pull/45119/files#r1537466016
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 26, 2024
@reylejano reylejano mentioned this issue Mar 26, 2024
Merged
@pranav-pandey0804
Copy link

/language en
/sig docs

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 27, 2024
@a-mccarthy
Copy link
Contributor

@reylejano do you feel like there is any restructuring of content that needs to happen with this move? Or is it a request to straight move those sections from one page to another?

@sftim
Copy link
Contributor

sftim commented Apr 5, 2024

/triage accepted

I think a straightforward move is the right change to prioritize. Extra help is welcome but not at the expense of delivering the fix later.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 5, 2024
@sftim
Copy link
Contributor

sftim commented Apr 14, 2024

/priority important-longterm

see https://github.com/kubernetes/website/pull/45119/files#r1537466016

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 14, 2024
@mrgiles
Copy link
Contributor

mrgiles commented Apr 23, 2024

/assign

@mrgiles mrgiles mentioned this issue Apr 24, 2024
Merged
@mrgiles
Copy link
Contributor

mrgiles commented Apr 24, 2024

@reylejano see if this PR does what you're looking for. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrgiles mrgiles

Labels
language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move node shutdown section to cluster-administration mrgiles/kubernetes-website
6 participants
@mrgiles @k8s-ci-robot @a-mccarthy @sftim @reylejano @pranav-pandey0804