Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation notice for https://kubernetes.io/docs/reference/tools/map-crictl-dockercli/ #41385

Closed
sftim opened this issue May 30, 2023 · 7 comments · Fixed by #41407
Closed

Fix deprecation notice for https://kubernetes.io/docs/reference/tools/map-crictl-dockercli/ #41385

sftim opened this issue May 30, 2023 · 7 comments · Fixed by #41407
Assignees
@Ritikaa96
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
1.28

Comments

@sftim
Copy link
Contributor

sftim commented May 30, 2023

This is a Bug Report

Problem:
https://v1-26.docs.kubernetes.io/docs/reference/tools/map-crictl-dockercli/ still says that the page will be removed in v1.27
https://kubernetes.io/docs/reference/tools/map-crictl-dockercli/ doesn't, and the page is still there.

I agree with not removing the page outright. However, could we perhaps replace that whole page with a link to
https://v1-24.docs.kubernetes.io/docs/reference/tools/map-crictl-dockercli/ and a brief note about why we have done so?

Proposed Solution:

Replace that whole page with a link to
https://v1-24.docs.kubernetes.io/docs/reference/tools/map-crictl-dockercli/ and a brief note about why we have done so?

We can also backport it so that

link to https://v1-24.docs.kubernetes.io/docs/reference/tools/map-crictl-dockercli/ as well

Page to Update:
https://kubernetes.io/docs/reference/tools/map-crictl-dockercli/

Additional Information:

/language en
/sig node
/kind bug

/milestone 1.28
@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone May 30, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 30, 2023
@Ritikaa96
Copy link
Contributor

We can do something like:

This page is being directed to https://v1-24.docs.kubernetes.io/docs/reference/tools/map-crictl-dockercli/ because of Removal of dockershim from crictl in v1.24 and
as per our community policy to not continue maintainership of deprecated doc beyond three versions
To find the reason for deprecation see here

@SergeyKanzhelev
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 31, 2023
@Ritikaa96
Copy link
Contributor

/assign

@Ritikaa96
Copy link
Contributor

I'd start the work and should i backport v1.26 and ,v1.27 as well?

We can also backport it so that

link to https://v1-24.docs.kubernetes.io/docs/reference/tools/map-crictl-dockercli/ as well

@Ritikaa96 Ritikaa96 mentioned this issue Jun 1, 2023
Merged
@Ritikaa96
Copy link
Contributor

Raised a PR , adding the link to redirect to v1.24 ,
Please confirm if i should backport v1.26 content just the same as well.

@Ritikaa96
Copy link
Contributor

Ritikaa96 commented Jul 14, 2023 •
edited
Loading

Hi, @sftim Raised a PR for change in v1.27 docs.
should I do the change in v1.26 ?

@Ritikaa96 Ritikaa96 mentioned this issue Jul 14, 2023
Closed
@Ritikaa96
Copy link
Contributor

Added v1.26 changes in #42017, PTAL!!

@kannon92 kannon92 moved this to Done in SIG Node Bugs Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ritikaa96 Ritikaa96

Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node Bugs
Archived in project
Milestone
1.28
Development

Successfully merging a pull request may close this issue.

fixing deprecation note for map-crictl-dockercli deprecation Ritikaa96/website
4 participants
@SergeyKanzhelev @k8s-ci-robot @sftim @Ritikaa96