Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNCF logo element ID collides with content #14575

Closed
sftim opened this issue May 28, 2019 · 3 comments · Fixed by #14577
Closed

CNCF logo element ID collides with content #14575

sftim opened this issue May 28, 2019 · 3 comments · Fixed by #14577
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@sftim
Copy link
Contributor

sftim commented May 28, 2019

This is a Bug Report

Problem: @praseodym highlighted that any HTML element with ID #cncf gets a logo added. This is blocking a pull request to address #14538; in the PR I wanted to put in a glossary entry with term_id set to cncf.

Proposed Solution:

  • Modify the content or glossary code generator so that no id="cncf" element gets created
  • Modify the CSS rule to something like #cncf-logo and also update HTML anywhere it gets used.
@sftim
Copy link
Contributor Author

sftim commented May 28, 2019

If it's feasible to use a narrower selector (than just #cncf) then that also seems like a legit fix.
Eg: #home section#cncf

@sftim sftim mentioned this issue May 28, 2019
Merged
@sftim
Copy link
Contributor Author

sftim commented May 28, 2019

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 28, 2019
@sftim
Copy link
Contributor Author

sftim commented Jun 26, 2019

Any objections to this getting fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only use CNCF logo style on home page sftim/kubernetes-website
2 participants
@k8s-ci-robot @sftim