Add cluster e2e for cri-containerd. #5370
Conversation
Random-Liu
requested review from
BenTheElder,
krzyzacy and
michelle192837
as code owners
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
| ENABLE_POD_SECURITY_POLICY=true | ||
|
|
||
| # Envs for cri-containerd. | ||
| KUBE_MASTER_EXTRA_METADATA="user-data=${GOPATH}/src/github.com/kubernetes-incubator/cri-containerd/test/e2e/master.yaml,cri-containerd-configure-sh=${GOPATH}/src/github.com/kubernetes-incubator/cri-containerd/test/configure.sh" |
There was a problem hiding this comment.
we don't allow $Var in env file, it's not gonna expand. Maybe just use /go/src/... here?
There was a problem hiding this comment.
Done. Changed to reply on cwd.
Random-Liu
force-pushed
the
add-cri-containerd-e2e
branch
from
20ad4f8
to
96420c5
Compare
| # For now explicitly test etcd v2 mode in this suite. | ||
| STORAGE_BACKEND=etcd2 | ||
| TEST_ETCD_IMAGE=2.2.1 | ||
| TEST_ETCD_VERSION=2.2.1 |
There was a problem hiding this comment.
(do you still wanna test against old etcd?, up to you)
There was a problem hiding this comment.
I see that all tests are still using this.
There was a problem hiding this comment.
yeah the e2e-gce uses this which I'm not sure why, anyway
There was a problem hiding this comment.
At least ci-kubernetes-e2e-gci-gce.env is still using it.
| "--check-leaked-resources", | ||
| "--env-file=jobs/platform/gce.env", | ||
| "--env-file=jobs/env/ci-cri-containerd-e2e-gce.env", | ||
| "--extract=ci/latest", |
There was a problem hiding this comment.
I think after --extract cwd will become /workspace/kubernetes, before that it's inside the repo. Is this still correct?
There was a problem hiding this comment.
--extract=ci/latest will hit https://github.com/kubernetes/test-infra/blob/master/kubetest/main.go#L368-L372
There was a problem hiding this comment.
if you wanna merge and watch the actual behavior I'm also fine
There was a problem hiding this comment.
Is extract=ci/latest required for e2e test?
Random-Liu
force-pushed
the
add-cri-containerd-e2e
branch
from
96420c5
to
049f013
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, Random-Liu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
@Random-Liu: I updated Prow config for you! In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add e2e test for cri-containerd.
This depends on kubernetes/kubernetes#54962.
We can get this merged first, but the test will keep failing until kubernetes/kubernetes#54962 is fixed.
For kubernetes/enhancements#286.