Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pj-on-kind doesn't work anymore #32443

Closed
ivanvc opened this issue Apr 13, 2024 · 4 comments · Fixed by #32446
Closed

pj-on-kind doesn't work anymore #32443

ivanvc opened this issue Apr 13, 2024 · 4 comments · Fixed by #32446
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@ivanvc
Copy link
Member

ivanvc commented Apr 13, 2024

What happened:

After the merge of #32418, it seems like config/pj-on-kind.sh wasn't properly cleaned up. It still refers to prow/pj-on-kind.sh, which no longer exists in the repo. See:

"${root}/prow/pj-on-kind.sh" "$@"

What you expected to happen:

Either config/pj-on-kind.sh should work or be removed from the repository. However, after merging #32418, the documentation (https://docs.prow.k8s.io/docs/build-test-update) on how to test Prow jobs locally is also outdated.

How to reproduce it (as minimally and precisely as possible):

  • Open a terminal, run ./config/pj-on-kind.sh, it returns the error:
    ./config/pj-on-kind.sh: line 26: /homa/ivan/Code/test-infra/prow/pj-on-kind.sh: No such file or directory
    
  • Open https://docs.prow.k8s.io/docs/build-test-update/#using-pj-on-kindsh. It still references pj-on-kind.sh and other ways to run Prow jobs locally as if they were still in this repository.

Please provide links to example occurrences, if any:

Anything else we need to know?:

@ivanvc ivanvc added the kind/bug Categorizes issue or PR as related to a bug. label Apr 13, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 13, 2024
@k8s-ci-robot
Copy link
Contributor

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Apr 15, 2024

@cjwagner the description references your PR, are you able to take a look at this?

Thanks

cc: @BenTheElder

@cjwagner
Copy link
Member

Yes, there is a trivial fix required for the config/pj-on-kind.sh script in this repo. The comment at the bottom of the script hints at what this is. I'll make a quick PR to fix it.

Open https://docs.prow.k8s.io/docs/build-test-update/#using-pj-on-kindsh. It still references pj-on-kind.sh and other ways to run Prow jobs locally as if they were still in this repository.

pj-on-kind.sh does still exist in the same relative path that it did before. It was just moved with the rest of the Prow source code to kubernetes-sigs/prow. The docs are still valid, there are just some links that are broken due to the code moving repos. Feel free to open an issue about the broken links in kubernetes-sigs/prow (or even better open a PR 😄 ).

@cjwagner
Copy link
Member

Looks like links in the docs are being fixed here: kubernetes-sigs/prow#103
I just reviewed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants