Post onboarding information for new contributors' first PR

[xiangpengzhao]

There are so many PRs named Release 1.6 which are created by new contributors.

kubernetes/kubernetes#47418
kubernetes/kubernetes#46616
kubernetes/kubernetes#45470
kubernetes/kubernetes#45396
kubernetes/kubernetes#45205
kubernetes/kubernetes#44823
kubernetes/kubernetes#44183
kubernetes/kubernetes#43733
kubernetes/kubernetes#43547
......

These PRs have the same name and the same info as below:
xx wants to merge xx commits into master from release-1.6

They're obviously created by some same mistake. The creator might haven't read the develop docs before they create the PR. They might not know where to find the docs.

We'd better let bot post some onboarding information when it detects a PR is created by a new contributor. So that they can know what's the correct process to create a PR. This will help them not make mistake next time whether their first process is correct or not.

xref:
kubernetes-retired/contrib#1090
kubernetes/kubernetes#36596

/cc @bgrant0607 @ConnorDoyle @grodrigues3

[fejta]

How do we know if it is their first PR? Might make for an interesting welcome plugin (maintain a list of seen users?)

[BenTheElder]

I think the most workable solution right now is to make sure the default PR text points you to the contributor guide (which I think it already does now?)

AFAIK you can scrape GitHub for contributor data but there isn't a great way to check per user.
So we'd have to maintain a contributors database ourselves, which would probably be pretty clunky. Example of finding contributors here.
Edit wrong link, I was thinking of this.

[bgrant0607]

Independently of detecting new contributors it may be useful to detect PRs to the wrong branch, PRs with excessive numbers of commits to the master branch, and other obvious mistakes.

[fejta]

PR Linter? I like it

[xiangpengzhao]

Independently of detecting new contributors it may be useful to detect PRs to the wrong branch, PRs with excessive numbers of commits to the master branch, and other obvious mistakes.

Great idea!

[0xmichalis]

/area prow

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[justaugustus]

/remove-lifecycle stale

[BenTheElder]

I don't think there's API access to this yet but they're definitely tracking first time contributors in the GitHub web interface now.

[nikhita]

/sig contributor-experience

[BenTheElder]

This came up again in #sig-contribex slack today, I think we could do this if we:

• used a dedicated bot account to do the queries
• just loaded the first page of results from searching for the user's PRs in the repo

If the number of results is exactly one and there are no other pages, it's a new contributor.

This would cost one extra token for every opened PR, which should definitely be very manageable on a dedicated account (it might even be manageable on the existing accounts?). Ex for @nikhita's PRs in test-infra (currently 12):

[BenTheElder]

/assign

[nikhita]

. Ex for @nikhita's PRs in test-infra (currently 12)

That's weird because I only have 11 PRs in test-infra. All of them have been merged and none is open right now: https://github.com/kubernetes/test-infra/pulls?q=is%3Apr+author%3Anikhita+is%3Aclosed.

[BenTheElder]

Ah, there's a typo in that, there shouldn't be a space after is:, which is not restricting it to PRs, so it's actually counting commits.

[BenTheElder]

fixed example:
https://developer.github.com/v4/explorer/?variables=%20%7B%0D%0A%20%20%22query%22%3A%20%22is%3Apr%20repo%3Akubernetes%2Ftest-infra%20author%3Anikhita%22%0D%0A%7D&query=query%20%28%24query%3A%20String%21%29%20%7B%0D%0A%20%20search%28query%3A%20%24query%2C%20type%3A%20ISSUE%29%20%7B%0D%0A%20%20%20%20issueCount%0D%0A%20%20%7D%0D%0A%20%20rateLimit%20%7B%0D%0A%20%20%20%20limit%0D%0A%20%20%20%20cost%0D%0A%20%20%20%20remaining%0D%0A%20%20%20%20resetAt%0D%0A%20%20%7D%0D%0A%7D%0D%0A

[matthyx]

/remove-help

[stevekuznetsov]

Implemented in #8643
/close

[k8s-ci-robot]

@stevekuznetsov: Closing this issue.

In response to this:

Implemented in #8643
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BenTheElder]

/reopen
we still need to enable and validate this feature, I can do that today
then we'll want to track getting a real, good welcome message configured

[k8s-ci-robot]

@BenTheElder: Reopening this issue.

In response to this:

/reopen
we still need to enable and validate this feature, I can do that today
then we'll want to track getting a real, good welcome message configured

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BenTheElder]

#9227 to enable testing this on test-infra

[BenTheElder]

#9231 did not work, I think
the query works but possibly we need to delay checking as the API does not immediately reflect this? we need to check for <= 1 instead of exactly 1 😬

[BenTheElder]

filed a fix #9232

[BenTheElder]

can confirm that this works now #9350 (comment)

[spiffxp]

What's keeping this open at this point?

[xiangpengzhao]

Seems like it's done. I'm okay to close it. @BenTheElder any other concerns ? Feel free to close it if needed.

[BenTheElder]

We still need to actually post onboarding info. The tooling works but the words need smithing :+)

[xiangpengzhao]

@BenTheElder is the plugin deployed in k/website? I don't see the onboarding info in kubernetes/website#10712

[nikhita]

is the plugin deployed in k/website?

@xiangpengzhao Nope, only test-infra.

test-infra/prow/plugins.yaml

Lines 207 to 210 in c4ad32d

	welcome:
	- repos:
	- kubernetes/test-infra
	message_template: "Welcome @{{.AuthorLogin}}! It looks like this is your first PR to {{.Org}}/{{.Repo}} 🎉🎉"

[xiangpengzhao]

Thanks @nikhita !

[BenTheElder]

poke! this plugin seems to be working pretty well where it is deployed, we just need to do #9367 (comment) and then roll it out more widely

[BenTheElder]

this is basically done?

it might be rolled out more at some point, but the tooling is there and enabled for some repos at least.

[nikhita]

this is basically done?

Yup. Thanks Ben and Guin! :)

/close

[k8s-ci-robot]

@nikhita: Closing this issue.

In response to this:

this is basically done?

Yup. Thanks Ben and Guin! :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BenTheElder]

FWIW last I saw still it was still not enabled generally.

…

On Mon, Apr 15, 2019, 08:08 Kubernetes Prow Robot ***@***.***> wrote: @nikhita <https://github.com/nikhita>: Closing this issue. In response to this <#3083 (comment)> : this is basically done? Yup. Thanks Ben and Guin! :) /close Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3083 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4Bq3VYfUCOhXfXt879mK05XLLjbl1Dks5vhJXagaJpZM4N7_va> .

[nikhita]

/reopen

[k8s-ci-robot]

@nikhita: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nikhita]

Will follow up on this next week

[nikhita]

FWIW last I saw still it was still not enabled generally.

Thought so too....but turns out it is :P

test-infra/prow/plugins.yaml

Lines 287 to 294 in b23cfa0

	welcome:
	- repos:
	- kubernetes
	- kubernetes-client
	- kubernetes-csi
	- kubernetes-incubator
	- kubernetes-sigs
	message_template: "Welcome @{{.AuthorLogin}}! <br><br>It looks like this is your first PR to <a href='https://github.com/{{.Org}}/{{.Repo}}'>{{.Org}}/{{.Repo}}</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if {{.Org}}/{{.Repo}} has [its own contribution guidelines](https://github.com/{{.Org}}/{{.Repo}}/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:"

[nikhita]

/close

[k8s-ci-robot]

@nikhita: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.