Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track containers not rebased to distroless #569

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Track containers not rebased to distroless #569

merged 1 commit into from
Mar 28, 2019

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Mar 27, 2019

As part of the effort on sig-release KEP "Rebase k8s images to distroless", we allow certain kinds of images rebasing to k8s.gcr.io/debian-base instead of distroless for now. This list is used to track containers not rebased to distroless in v1.15.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2019
@k8s-ci-robot k8s-ci-robot requested review from foxish and listx March 27, 2019 16:36
@yuwenma
Copy link
Contributor Author

yuwenma commented Mar 27, 2019

/assign justaugustus
/assign calebamiles

@yuwenma
Copy link
Contributor Author

yuwenma commented Mar 27, 2019

/cc @tallclair

@k8s-ci-robot k8s-ci-robot requested a review from tallclair March 27, 2019 16:40
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit b5b6cfa into kubernetes:master Mar 28, 2019
@tallclair
Copy link
Member

Thanks for adding this. I missed it when it went in, but can you add a small heading that explains the context for this list? Maybe an brief explanation and a link to the KEP

@yuwenma
Copy link
Contributor Author

yuwenma commented Apr 16, 2019

Thanks for adding this. I missed it when it went in, but can you add a small heading that explains the context for this list? Maybe an brief explanation and a link to the KEP

Gotcha, will update the list and add more descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants