Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of drop capabilities using ALL #11

Closed
qu1queee opened this issue Jul 4, 2023 · 2 comments
Closed

Behaviour of drop capabilities using ALL #11

qu1queee opened this issue Jul 4, 2023 · 2 comments

Comments

@qu1queee
Copy link

qu1queee commented Jul 4, 2023

Quick question, if we want to set the ALL entry for the capabilities.drop , is there a difference on using ALL vs all . On PSP definitions, we use to set all, but it seems PSA is opinionated on allowing only ALL. Is there any context you can provide on this?

@qu1queee qu1queee changed the title Behaviour of drop capabilities Behaviour of drop capabilities using ALL Jul 4, 2023
@joebowbeer
Copy link

joebowbeer commented Jul 4, 2023

The PSS/restricted spec does explicitly require 'ALL' and the Pod Security Admission controller implementation requires 'ALL' as well.

My understanding is as follows based on correspondence with @tallclair

  • In practice, cri-o and containerd appear to do case-insensitive matching for the ALL keyword, but this is not guaranteed to work for other runtimes.
  • Until a stricter CRI capabilities spec is championed in SIG-Node, it's preferable and arguably more correct for the PSS policies to stick to the canonical ALL capitalization. That way they will be consistent with each other as well as their own spec.
  • It is very unlikely that the PSA implementation will change without a corresponding change to the CRI capabilities spec.

This is one of the axes I grind, e.g., kyverno/policies#450

@qu1queee
Copy link
Author

qu1queee commented Jul 4, 2023

@joebowbeer thanks for the prompt response.

The provided context is sufficient for my use case and general doubts, please feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants