Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kubernets version script does not generate unit tests #9694

Closed
medyagh opened this issue Nov 13, 2020 · 1 comment · Fixed by #9708
Closed

update kubernets version script does not generate unit tests #9694

medyagh opened this issue Nov 13, 2020 · 1 comment · Fixed by #9708
Assignees
@prezha
Labels
kind/process Process oriented issues, like setting up CI priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Nov 13, 2020

in this PR #9693
I used the script

cd hack/update/kubernetes_version
go run update_kubernetes_version.go

it changed the constants.go and the docs but it did not change these files and didn't add a folder of unit test data

pkg/minikube/bootstrapper/bsutil/kubeadm_test.go
pkg/minikube/bootstrapper/bsutil/testdata/v1.20.0-beta.1
@medyagh medyagh added kind/process Process oriented issues, like setting up CI priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 13, 2020
@prezha
Copy link
Contributor

prezha commented Nov 13, 2020

/assign

This was referenced Nov 15, 2020
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prezha prezha

Labels
kind/process Process oriented issues, like setting up CI priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
2 participants
@medyagh @prezha