-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automate pushing kicbase image from snapshot to stable after release #9420
Labels
kind/process
Process oriented issues, like setting up CI
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Comments
medyagh
added
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/process
Process oriented issues, like setting up CI
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
and removed
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
labels
Oct 8, 2020
/assign |
@medyagh i've created pr (#9439) to automate pushing kicbase image, please have a look a few notes:
please share your thoughts |
This was referenced Oct 14, 2020
@medyagh i've assumed that:
so this issue should be covered now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/process
Process oriented issues, like setting up CI
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
before release each time we build the kic base image we add the snashotX to it
for example
https://github.com/medyagh/minikube/blob/32922f4184c31fb405fb8dab7a1d7a8ef120b47a/pkg/drivers/kic/types.go#L27
Version = "v0.0.13-snapshot1"
this is good for when multiple people make corrections before a release, and once it is finalized, before the release we do this
and change the types.go in kic package
https://github.com/medyagh/minikube/blob/32922f4184c31fb405fb8dab7a1d7a8ef120b47a/pkg/drivers/kic/types.go#L27
The text was updated successfully, but these errors were encountered: