Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate pushing kicbase image from snapshot to stable after release #9420

Closed
medyagh opened this issue Oct 8, 2020 · 3 comments · Fixed by #9439, #9464 or #9532
Closed

automate pushing kicbase image from snapshot to stable after release #9420

medyagh opened this issue Oct 8, 2020 · 3 comments · Fixed by #9439, #9464 or #9532
Assignees
Labels
kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@medyagh
Copy link
Member

medyagh commented Oct 8, 2020

before release each time we build the kic base image we add the snashotX to it
for example
https://github.com/medyagh/minikube/blob/32922f4184c31fb405fb8dab7a1d7a8ef120b47a/pkg/drivers/kic/types.go#L27
Version = "v0.0.13-snapshot1"

this is good for when multiple people make corrections before a release, and once it is finalized, before the release we do this

docker tag kicbase/stable:v0.0.13-snapshot1 kicbase/stable:v0.0.13
docker tag kicbase/stable:v0.0.13 gcr.io/k8s-minikube/kicbase:v0.0.13
docker tag kicbase/stable:v0.0.13 docker.pkg.github.com/kubernetes/minikube/kicbase:v0.0.13
docker push kicbase/stable:v0.0.13
docker push gcr.io/k8s-minikube/kicbase:v0.0.13
docker push docker.pkg.github.com/kubernetes/minikube/kicbase:v0.0.13

and change the types.go in kic package
https://github.com/medyagh/minikube/blob/32922f4184c31fb405fb8dab7a1d7a8ef120b47a/pkg/drivers/kic/types.go#L27

@medyagh medyagh added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 8, 2020
@prezha
Copy link
Contributor

prezha commented Oct 9, 2020

/assign

@prezha
Copy link
Contributor

prezha commented Oct 11, 2020

@medyagh i've created pr (#9439) to automate pushing kicbase image, please have a look

a few notes:

  • there are some env vars required for passing credentials (details are in code comments)
  • "GitHub Packages Docker registry will be superseded by GitHub Container Registry." (ref) - maybe we should plan to migrate in (near) future
  • this pr does not cover updating corresponding Version in types.go in kic package atm - reason: open questions & proposal:
  1. out of the three registries, what is/are minimally acceptable combination(s) of successful/failed updates - ie, which we would accept to fail and still update Version in pkg/drivers/kic/types.go? eg, just gcr is enough, or, at least gcr and one another, or, all three must be updated, etc.
  2. when we (locally) update the Version in types.go, wouldn't we also want a pr to be automatically created (if one doesn't exist already)? that would also allow it to run as a standalone script
    if so, we could nicely combine this with eg, issue update go version to be 1.15 in go mod #9264 (i have improved version) with the approach proposed in issue Write a script to automatically propose PR's due to a new Kubernetes release #4392 (pr update_kubernetes_version: standalone script v2 #9384) and potentially any other issue that needs versions or any other value(s) updated in file(s)
    here, i would send out a complete proposal, just waiting to first agree on the proposed approach in issue Write a script to automatically propose PR's due to a new Kubernetes release #4392 (pr update_kubernetes_version: standalone script v2 #9384) and confirmation that the existing pr Upgrade go version to 1.15.2 #9280 is correct

please share your thoughts

@prezha
Copy link
Contributor

prezha commented Oct 14, 2020

@medyagh i've assumed that:

  1. it would be acceptable to have at least one registry updated (that can be easily changed if needed), and so
  2. i've included the updating corresponding Version in types.go in kic package, as well as automatically creating respective (unique) pr, as part of pr Add hack/update package to automate PR generation #9464

so this issue should be covered now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
2 participants