Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition between dockerd and containerd #8203

Closed
afbjorklund opened this issue May 19, 2020 · 1 comment · Fixed by #8518
Closed

Race condition between dockerd and containerd #8203

afbjorklund opened this issue May 19, 2020 · 1 comment · Fixed by #8518
Assignees
@afbjorklund
Labels
area/guest-vm General configuration issues with the minikube guest VM co/runtime/docker Issues specific to a docker runtime kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.12.0

Comments

@afbjorklund
Copy link
Collaborator

Currently the VM startup procedure relies on Docker starting an internal version of containerd.

But depending on timing, dockerd can choose to start using the systemd version instead...

See https://github.com/moby/moby/blob/v19.03.8/cmd/dockerd/daemon_unix.go#L155

This leads to the docker daemon not responding, when minikube shuts down system containerd.

We should probably do like the ubuntu packaging, and have docker.service use containerd.service

BindsTo=containerd.service and dockerd --containerd=/run/containerd/containerd.sock
@afbjorklund afbjorklund added co/runtime/docker Issues specific to a docker runtime area/guest-vm General configuration issues with the minikube guest VM priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 19, 2020
@afbjorklund
Copy link
Collaborator Author

This is related to the KIC configuration and Ubuntu provisioning, that looks for this situation: #7595

@priyawadhwa priyawadhwa added the kind/bug Categorizes issue or PR as related to a bug. label May 19, 2020
@afbjorklund afbjorklund mentioned this issue May 22, 2020
Closed
@afbjorklund afbjorklund mentioned this issue Jun 7, 2020
Closed
@afbjorklund afbjorklund added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 7, 2020
@afbjorklund afbjorklund added this to the v1.12.0-candidate milestone Jun 7, 2020
@priyawadhwa priyawadhwa mentioned this issue Jun 15, 2020
Closed
@afbjorklund afbjorklund mentioned this issue Jun 20, 2020
Merged
@afbjorklund afbjorklund self-assigned this Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbjorklund afbjorklund

Labels
area/guest-vm General configuration issues with the minikube guest VM co/runtime/docker Issues specific to a docker runtime kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging a pull request may close this issue.

Make sure to use internal containerd for docker afbjorklund/minikube
2 participants
@afbjorklund @priyawadhwa