Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add APIServer endpoint to minikube profile list #6642

Open
balopat opened this issue Feb 14, 2020 · 6 comments
Open

add APIServer endpoint to minikube profile list #6642

balopat opened this issue Feb 14, 2020 · 6 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. ux/embedded Embedded UX blockers

Comments

@balopat
Copy link
Contributor

balopat commented Feb 14, 2020

For Skaffold (GoogleContainerTools/skaffold#3668) we know the current context. That context has an API server endpoint:

- cluster:
    certificate-authority: /Users/.../.minikube/ca.crt
    server: https://127.0.0.1:32777
  name: docker3

I want to be able to join my API Server endpoint to a minikube profile.

Currently this is not possible for the Docker driver, as the Node spec contains the node IP not the API Server endpoint:

....
 "Nodes": [
          {
            "Name": "docker3",
            "IP": "172.17.0.4",
            "Port": 8443,
            "KubernetesVersion": "v1.17.2",
            "ControlPlane": true,
            "Worker": true
          }
...

Can we add a cluster-wide property, APIServer to the json listing?

@balopat balopat added co/runtime/docker Issues specific to a docker runtime co/docker-driver Issues related to kubernetes in container co/multinode Issues related to multinode clusters labels Feb 14, 2020
@medyagh
Copy link
Member

medyagh commented Feb 15, 2020

@balopat that is a good idea ! we could add a field,
"ApiserverEndpoint"
in VM world they used to be the same, but in docker/podman driver it is a different story.

We could do that.

@medyagh medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 15, 2020
@medyagh medyagh self-assigned this Feb 19, 2020
@sharifelgamal sharifelgamal added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2020
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers and removed co/docker-driver Issues related to kubernetes in container co/multinode Issues related to multinode clusters co/runtime/docker Issues specific to a docker runtime priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 18, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 16, 2020
@sharifelgamal
Copy link
Collaborator

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 17, 2020
@priyawadhwa priyawadhwa added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 23, 2020
@tharun208
Copy link
Contributor

@medyagh , I like to work on this

@briandealwis
Copy link
Contributor

An alternative is to add the profile name to the context and cluster extensions as Minikube is now doing with cluster_info:

- cluster:
    certificate-authority: /Users/bdealwis/.minikube/ca.crt
    extensions:
    - extension:
        last-update: Mon, 22 Mar 2021 21:45:57 EDT
        provider: minikube.sigs.k8s.io
        version: v1.18.1
      name: cluster_info
    server: https://127.0.0.1:61837
  name: containerd

Then the minikube instance could remain blissfully ignorant of how its endpoints are exposed to the host environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. ux/embedded Embedded UX blockers
Projects
None yet
Development

No branches or pull requests

9 participants