Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minikube IP to NO_PROXY if HTTPS_PROXY is set #4130

Closed
tstromberg opened this issue Apr 22, 2019 · 2 comments · Fixed by #4229
Closed

Add minikube IP to NO_PROXY if HTTPS_PROXY is set #4130

tstromberg opened this issue Apr 22, 2019 · 2 comments · Fixed by #4229
Assignees
@medyagh
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.1.0

Comments

@tstromberg
Copy link
Contributor

This avoids the issue of folks not being able to contact the apiserver.
@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 22, 2019
@tstromberg tstromberg added this to the v1.1.0-candidate milestone Apr 22, 2019
@tstromberg tstromberg mentioned this issue Apr 22, 2019
Closed
@tstromberg tstromberg added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 1, 2019
@tstromberg
Copy link
Contributor Author

There is also HTTP_PROXY, but this is not used as far as I know at the moment.

@tstromberg
Copy link
Contributor Author

As an alternative, we could also configure the k8s API client so that it ignores proxies altogether:

https://stackoverflow.com/questions/44291191/bypassing-http-proxy-in-golang

@tstromberg tstromberg assigned tstromberg and medyagh and unassigned tstromberg May 1, 2019
@medyagh medyagh mentioned this issue May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medyagh medyagh

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Allow minikube to function with misconfigured NO_PROXY value medyagh/minikube
2 participants
@tstromberg @medyagh